Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw_env parsing in config file should use partition, not split #691

Closed
xealot opened this issue Feb 5, 2014 · 3 comments
Closed

raw_env parsing in config file should use partition, not split #691

xealot opened this issue Feb 5, 2014 · 3 comments

Comments

@xealot
Copy link
Contributor

xealot commented Feb 5, 2014

The environment flag parsing will fail if the environment variable's value contains an '='.

gunicorn/gunicorn/config.py

Line 170 in f375f92

k, v = s.split('=')

This code should be switched to using partition, or at least specify a maxsplit.
@tilgovi
Copy link
Collaborator

tilgovi commented Feb 5, 2014

@xealot would you like to submit a patch?

xealot added a commit to xealot/gunicorn that referenced this issue Feb 6, 2014
@xealot
fixes issue benoitc#691, raw_env config file parsing
dbf6c76
@xealot xealot mentioned this issue Feb 6, 2014
Merged
benoitc added a commit that referenced this issue Feb 6, 2014
@benoitc
Merge pull request #692 from xealot/691-raw_env-fix
6e9644c 
fixes issue #691, raw_env config file parsing
@berkerpeksag
Copy link
Collaborator

Can this issue be closed now?

@xealot
Copy link
Contributor Author

xealot commented Mar 11, 2014

Sure.

@benoitc benoitc closed this as completed Mar 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benoitc @tilgovi @berkerpeksag @xealot