Fix ns export when between a default export and exported specifiers. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
commented
May 13, 2017
| @@ -156,10 +160,6 @@ function parseExportSpecifiersMaybe(parser, node) { | |||
| } | |||
| } | |||
|
|
|||
| function peekNextType(parser) { | |||
| return peekNextWith(parser, () => parser.type); | |||
| } | |||
There was a problem hiding this comment.
The bug was we were passing () => parser.type instead of (p) => p.type.
|
It turns out by spec order is significant, but I think that's goofy. I'll pull babylon until a proposal lands to support unordered import/export. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @benjamn. I found this bug but the \babylon compiler. Its having problems with:
The acorn parser works because of our extension (bug fix).
I've skipped the from-extensions from other babylon specific tests, but it will still error when using the babylon parser (the first iteration of the run.sh).