Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] Check permission checks #59

Closed
bembelimen opened this issue Apr 21, 2020 · 1 comment
Closed

[Workflow] Check permission checks #59

bembelimen opened this issue Apr 21, 2020 · 1 comment

Comments

@bembelimen
Copy link
Owner

Steps to reproduce the issue

Some checks do look a bit "smelly".. Like https://github.com/bembelimen/joomla-cms/blob/workflow-v3/administrator/components/com_workflow/src/Model/StageModel.php#L130

Expected result

Probly calculate the context from values from the database and not by request parameters
@HLeithner
Copy link

Yes I think that would be the better approach.

@bembelimen bembelimen mentioned this issue May 30, 2020
Merged
bembelimen pushed a commit that referenced this issue Dec 7, 2020
@richard67
Merge pull request #59 from richard67/development-color-switcher-mod-1
98fd6cf 
- Add new scss files to css build script so that css and css.min will be built.
- Correct typo "autumm" to "autumn" in file name, language string names and values andin the option value.
- Change "color" (en-US) to "colour" (en-GB) in language string values.
- Simplify option labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bembelimen @HLeithner