Some self review

belav · Jul 14, 2023 · e942cbf · e942cbf
1 parent df793ca
commit e942cbf
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -7,7 +7,6 @@
     <PackageVersion Include="BenchmarkDotNet.Annotations" Version="0.13.5" />
     <PackageVersion Include="CliWrap" Version="3.3.3" />
     <PackageVersion Include="DiffEngine" Version="6.5.7" />
-    <PackageVersion Include="editorconfig" Version="0.14.0" />
     <PackageVersion Include="FluentAssertions" Version="5.10.3" />
     <PackageVersion Include="Glob" Version="1.1.9" />
     <PackageVersion Include="Ignore" Version="0.1.48" />

diff --git a/Src/CSharpier.Cli/CSharpier.Cli.csproj b/Src/CSharpier.Cli/CSharpier.Cli.csproj
@@ -8,6 +8,7 @@
     <PackAsTool>true</PackAsTool>
     <AssemblyOriginatorKeyFile>../../Nuget/csharpier.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>True</SignAssembly>
+    <!-- TODO 1 why is this signed again? Glob is not so this causes headaches-->
     <PublicKey>002400000480000094000000060200000024000052534131000400000100010049d266ea1aeae09c0abfce28b8728314d4e4807126ee8bc56155a7ddc765997ed3522908b469ae133fc49ef0bfa957df36082c1c2e0ec8cdc05a4ca4dbd4e1bea6c17fc1008555e15af13a8fc871a04ffc38f5e60e6203bfaf01d16a2a283b90572ade79135801c1675bf38b7a5a60ec8353069796eb53a26ffdddc9ee1273be</PublicKey>
   </PropertyGroup>
   <ItemGroup>

diff --git a/Src/CSharpier.Cli/EditorConfig/EditorConfigParser.cs b/Src/CSharpier.Cli/EditorConfig/EditorConfigParser.cs
@@ -4,11 +4,13 @@ namespace CSharpier.Cli.EditorConfig;
 
 internal static class EditorConfigParser
 {
-    public static List<EditorConfigSections> GetAllForDirectory(
+    /// <summary>Finds all configs above the given directory as well as within the subtree of this directory</summary>
+    public static List<EditorConfigSections> FindForDirectoryName(
         string directoryName,
         IFileSystem fileSystem
     )
     {
+        // TODO 1 this may not actually find things above the current directory
         if (directoryName is "")
         {
             return new List<EditorConfigSections>();

diff --git a/Src/CSharpier.Cli/Options/ConfigurationFileOptions.cs b/Src/CSharpier.Cli/Options/ConfigurationFileOptions.cs
@@ -38,7 +38,8 @@ ConfigurationFileOptions configurationFileOptions
         };
     }
 
-    internal static List<CSharpierConfigData> FindForDirectory2(
+    /// <summary>Finds all configs above the given directory as well as within the subtree of this directory</summary>
+    internal static List<CSharpierConfigData> FindForDirectoryName(
         string directoryName,
         IFileSystem fileSystem,
         ILogger logger

diff --git a/Src/CSharpier.Cli/Options/OptionsProvider.cs b/Src/CSharpier.Cli/Options/OptionsProvider.cs
@@ -41,10 +41,13 @@ CancellationToken cancellationToken
             : null;
 
         var csharpierConfigs = configPath is null
-            ? ConfigurationFileOptions.FindForDirectory2(directoryName, fileSystem, logger)
+            ? ConfigurationFileOptions.FindForDirectoryName(directoryName, fileSystem, logger)
             : Array.Empty<CSharpierConfigData>().ToList();
 
-        var editorConfigSections = EditorConfigParser.GetAllForDirectory(directoryName, fileSystem);
+        var editorConfigSections = EditorConfigParser.FindForDirectoryName(
+            directoryName,
+            fileSystem
+        );
         var ignoreFile = await IgnoreFile.Create(directoryName, fileSystem, cancellationToken);
 
         return new OptionsProvider(