Correct the fallback handling when an icon cannot be loaded. #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested review from
mhsmith
and removed request for
mhsmith and
rmartin16
mhsmith
reviewed
May 7, 2024
Comment on lines
+137
to
+138
| def test_create_fallback_unloadable(monkeypatch, app, capsys): | ||
| """If a resource exists, but can't be loaded, an error is raised.""" |
There was a problem hiding this comment.
This should be documented. Right now the Icon documentation doesn't mention the possibility of raising any exceptions at all.
mhsmith
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the macOS backend can't find the icon file, it is currently raised as a ValueError. This should be a FileNotFound error, so that fallback logic is activated.
It also modifies the icon lookup logic to ask specifically for a
.icnsresource, rather than relying on CFBundleIconFile to provide the extension.Fixes #2558.
PR Checklist: