-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run helloworld on macOS after 0.4.3 release #2558
Comments
This only appears to affect the |
Indeed; I had to target Xcode to trigger the error in my VM. |
The issue appears to be in the Info.plist for the generated template; it's not adding the .icns extension to the CFBundleIconFile attribute. |
There's a secondary problem in that the ValueError being raised when an icon can't be loaded isn't being caught by the base Icon class. I'll push a fix for both of these shortly. The Info.plist can be fixed by backporting the template change; that will be enough to avoid immediate problems. The base Icon class fix will need a new Toga release. EDIT: To clarify - we would need to cut a new release to get the fix for this bug into the wild. I think we can live with just the template fix for the short term. |
Hrm... I take that back - it might not be that simple. I thought it was just a fix to the input metadata, but it looks like Xcode transforms that value on its way to the final build product. We might need to do a 0.4.5 release to correct this. |
Describe the bug
The helloworld app fails to run on macOS.
Briefcase CI is also failing: https://github.com/beeware/briefcase/actions/runs/8973799632/job/24646416726?pr=1778
Traceback:
Steps to reproduce
briefcase new --no-input && cd helloworld && briefcase run macos xcode
Expected behavior
Tutorial helloworld app builds and runs on macOS.
Screenshots
No response
Environment
0.3.18
0.4.3
Logs
briefcase.2024_05_06-15_08_56.run.log
Additional context
No response
The text was updated successfully, but these errors were encountered: