Flake8 tweaks

.github/workflows/ci.yml

@@ -18,6 +18,11 @@ defaults:
   run:
     shell: bash
 
+# Cancel active CI runs for a PR before starting another run
+concurrency:
+  group: ${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   pre-commit:
     name: Pre-commit checks

changes/1835.misc.rst

@@ -0,0 +1 @@
+Removed unnecessary ``noqa`` markers for flake8 and simplified the configuration.

cocoa/src/toga_cocoa/window.py

@@ -213,7 +213,7 @@ def set_content(self, widget):
         # bigger. If the window is resizable, using >= allows the window to
         # be dragged larged; if not resizable, it enforces the smallest
         # size that can be programmattically set on the window.
-        self._min_width_constraint = NSLayoutConstraint.constraintWithItem_attribute_relatedBy_toItem_attribute_multiplier_constant_(  # NOQA: E501
+        self._min_width_constraint = NSLayoutConstraint.constraintWithItem_attribute_relatedBy_toItem_attribute_multiplier_constant_(  # noqa: E501
             widget.native,
             NSLayoutAttributeRight,
             NSLayoutRelationGreaterThanOrEqual,
@@ -224,7 +224,7 @@ def set_content(self, widget):
         )
         widget.native.addConstraint(self._min_width_constraint)
 
-        self._min_height_constraint = NSLayoutConstraint.constraintWithItem_attribute_relatedBy_toItem_attribute_multiplier_constant_(  # NOQA: E501
+        self._min_height_constraint = NSLayoutConstraint.constraintWithItem_attribute_relatedBy_toItem_attribute_multiplier_constant_(  # noqa: E501
             widget.native,
             NSLayoutAttributeBottom,
             NSLayoutRelationGreaterThanOrEqual,

core/src/toga/colors.py

@@ -1,2 +1,2 @@
 # Use the Travertino color definitions as-is
-from travertino.colors import *  # noqa: F401,F403
+from travertino.colors import *  # noqa: F401, F403

core/src/toga/constants/__init__.py

@@ -1 +1 @@
-from travertino.constants import *  # noqa: F401,F403
+from travertino.constants import *  # noqa: F401, F403

core/src/toga/fonts.py

@@ -1,7 +1,7 @@
 import warnings
 
 # Use the Travertino font definitions as-is
-from travertino import constants  # noqa: F401
+from travertino import constants
 from travertino.constants import ITALIC  # noqa: F401
 from travertino.constants import (  # noqa: F401
     BOLD,
@@ -17,7 +17,7 @@
     SYSTEM,
 )
 from travertino.fonts import font  # noqa: F401
-from travertino.fonts import Font as BaseFont  # noqa: F401
+from travertino.fonts import Font as BaseFont
 
 from toga.platform import get_platform_factory
 

gtk/src/toga_gtk/container.py

@@ -155,7 +155,7 @@ def do_size_allocate(self, allocation):
         and that new geometry will be applied to all child widgets of the
         container.
         """
-        # print(self._content, f"Container layout {allocation.width}x{allocation.height} @ {allocation.x}x{allocation.y}")
+        # print(self._content, f"Container layout {allocation.width}x{allocation.height} @ {allocation.x}x{allocation.y}")  # noqa: E501
 
         # The container will occupy the full space it has been allocated.
         resized = (allocation.width, allocation.height) != (self.width, self.height)

gtk/src/toga_gtk/libs/gtk.py

@@ -3,7 +3,7 @@
 gi.require_version("Gdk", "3.0")
 gi.require_version("Gtk", "3.0")
 
-from gi.repository import Gdk, GdkPixbuf, Gio, GLib, GObject, Gtk  # noqa: F401, E402
+from gi.repository import Gdk, GdkPixbuf, Gio, GLib, GObject, Gtk  # noqa: E402, F401
 
 # The following import will fail if WebKit or its API wrappers aren't
 # installed; handle failure gracefully
@@ -13,19 +13,19 @@
 for version in ["4.0", "3.0"]:
     try:
         gi.require_version("WebKit2", version)
-        from gi.repository import WebKit2  # noqa: F401, E402
+        from gi.repository import WebKit2  # noqa: F401
 
         break
     except (ImportError, ValueError):
         pass
 
 try:
     gi.require_version("Pango", "1.0")
-    from gi.repository import Pango  # noqa: F401, E402
+    from gi.repository import Pango
 except ImportError:
     Pango = None
 
 try:
-    import cairo  # noqa: F401, E402
+    import cairo
 except ImportError:
     cairo = None

setup.cfg

@@ -1,4 +1,6 @@
 [flake8]
-max-complexity = 30
 max-line-length = 119
-ignore = E203,E266,E501,W503
+extend-ignore =
+    # whitespace before :
+    # See https://github.com/PyCQA/pycodestyle/issues/373
+    E203,