Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 tweaks #1835

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Flake8 tweaks #1835

merged 3 commits into from
Mar 31, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Mar 30, 2023

Changes

  • Remove unnecessary noqa markers and clarify unqualified markers
  • Simplify flake8 configuration
    • Remove max-complexity.....30 is pretty high and I'm guessing someone was just trying to disable the check
    • Use default list of checks to exclude
      • E266 - Too many leading '#' for block comment
        • This doesn't seem to be relevant anymore
      • E501 - Line too long
        • All (well, nearly all) of the problem cases were already marked
      • W503 - Line break occurred before a binary operator
        • In the default list of excluded checks
  • Update CI to cancel the current run if a PR receives new commits

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

- Remove unnecessary `noqa` markers and normalize others
- Simplify configuration
@rmartin16 rmartin16 marked this pull request as ready for review March 30, 2023 23:41
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 8bcd368 into beeware:main Mar 31, 2023
@rmartin16 rmartin16 deleted the flake8-tweaks branch March 31, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants