Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: use multiple existing tls certificates #100

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[common]: use multiple existing tls certificates #100

wants to merge 6 commits into from

Conversation

LeTT00r
Copy link

@LeTT00r LeTT00r commented Jun 13, 2023

What this PR does:

adds the ability to implement multiple existing tls certificates to ingress

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@LeTT00r
feat: use multiple existing tls certificates
56e076a 
Signed-off-by: MichaelBjeski <blabor@posteo.net>
@LeTT00r LeTT00r requested a review from a team as a code owner June 13, 2023 13:49
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 13, 2023
@adberger
Copy link
Contributor

helm-test / lint-test is failing, please fix.
Would also be nice to have multiple tls.provided so there is no need to create separate Secrets beforehand.
Why are there so many changes in charts/common/values.schema.json?

@LeTT00r
fix: version bump to 10.3.0
3017dbe 
fix: set host for each certificate directly

Signed-off-by: MichaelBjeski <blabor@posteo.net>
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 14, 2023
@LeTT00r
fix: add comments in tls part back in
4cbe7bf 
Signed-off-by: MichaelBjeski <blabor@posteo.net>
@LeTT00r
fix: correct helm-docs make
2bc78f8 
Signed-off-by: MichaelBjeski <blabor@posteo.net>
@LeTT00r
fix: updating helm template
2a72a08 
Signed-off-by: MichaelBjeski <blabor@posteo.net>
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023
@LeTT00r
feat: having multiple hosts for a certificate
7c48009 
Signed-off-by: MichaelBjeski <blabor@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverbaehler oliverbaehler Awaiting requested review from oliverbaehler oliverbaehler is a code owner automatically assigned from bedag/sre

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeTT00r @adberger