Support for Observables #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
pushed a commit
to danielsogl/awesome-cordova-plugins
that referenced
this pull request
Oct 4, 2019
* Add Basic WebSocketServer Class * Change for custom plugin fork * Set cordova observable property * Setup for custom fork of plugin Using custom fork for better support for observables. Use original repo when pull request becvert/cordova-plugin-websocket-server#64 is merged * Add Documentation * Remove double quotes with single quotes * Fix lint issues * Fix stop() docs
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #63
I managed to change it without touching any backend code. It should keep all the other functionalities the same, except the start and stop functions now return a single object.
The workaround for promises that you mentioned did not really work. It just splited the address string "0.0.0.0" to "0" and "."