fix some quoting issues, improve test coverage

beacon-biosignals · Sep 12, 2024 · 9fbdaac · 9fbdaac
1 parent b6522fa
commit 9fbdaac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/schemas.jl b/src/schemas.jl
@@ -644,7 +644,7 @@ function _generate_record_type_definitions(schema_version::SchemaVersion, record
             # tried to implement the warning for empty arguments by defining `$R()` we would
             # be defining the same method twice.
             function $R(flag::$Legolas.CheckArgsFlag=$Legolas.CheckArgs(); $(field_kwargs...))
-                $(result) = $Legolas._check_empty_args(flag, $string(R), $(keys(record_fields)...))
+                $(result) = $Legolas._check_empty_args(flag, $(string(R)), $(keys(record_fields)...))
                 $((:($key = $(result)[$i]) for (i, key) in enumerate(keys(record_fields)))...)
                 $parent_record_application
                 $(field_assignments...)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -691,6 +691,10 @@ end
     a::Integer = replace(a, ' ' => '-')
 end
 
+@version FieldErrorV4 begin
+    x::Union{String,Missing}
+end
+
 @testset "Legolas record constructor error handling" begin
     @testset "field constructor error" begin
         ex_stack = try
@@ -772,12 +776,16 @@ end
     end
 
     @testset "appropriate warnings with zero-argument constructor" begin
-        msg = r"no arguments passed.*FieldErrorV1.*are you sure.*FieldErrorV1SchemaVersion"i
+        msg = r"no arguments passed.*FieldErrorV.*are you sure.*FieldErrorV(1|4)SchemaVersion"i
 
         @test_logs (:warn, msg) FieldErrorV1()
         @test_logs FieldErrorV1(; a=missing)
         @test_logs FieldErrorV1((;))
 
+        @test_logs (:warn, msg) FieldErrorV4()
+        @test_logs FieldErrorV4(; x=missing)
+        @test_logs FieldErrorV4((;))
+
         @test_logs (:warn, msg) begin
             @test_throws ArgumentError FieldErrorV1{String,Int}()
         end