Merge pull request #270 from itarato/bugfix/PA-missing-gc-guard

[Bugfix] Fixing a rare bug when calling BCrypt::Engine#hash_secret - which produces nil accidentally 1 out of 500 cases
bcrypt-ruby · Jun 22, 2023 · d4e4813 · d4e4813
2 parents e402d69 + 53ec1e1
commit d4e4813
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/ext/mri/bcrypt_ext.c b/ext/mri/bcrypt_ext.c
@@ -49,6 +49,9 @@ static VALUE bc_salt(VALUE self, VALUE prefix, VALUE count, VALUE input) {
     if(!salt) return Qnil;
 
     str_salt = rb_str_new2(salt);
+
+    RB_GC_GUARD(prefix);
+    RB_GC_GUARD(input);
     free(salt);
 
     return str_salt;
@@ -99,6 +102,8 @@ static VALUE bc_crypt(VALUE self, VALUE key, VALUE setting) {
 
     out = rb_str_new2(value);
 
+    RB_GC_GUARD(key);
+    RB_GC_GUARD(setting);
     free(args.data);
 
     return out;