feat: add TS typings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Jun 23, 2019
| "convert-source-map": "^1.6.0", | ||
| "source-map": "^0.7.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^12.0.10", |
There was a problem hiding this comment.
this is a dev dep since it pollutes the global namespace (jestjs/jest#8092)
|
@SimenB 👋 I commented on the other PR, we've usually been adding types as a dev dependency, on the libraries I work on at Google, because it allows folks upstream to override the types more easily ... I don't have a strong opinion about the approach used, but curious to know the advantages of having it as a regular dependency. |
|
Answered on Slack, but to have it here as well - if it's part of the exported types from the module, it should be a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need these to use the module in Jest 🙂