Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make each integration test independent #79

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Make each integration test independent #79

merged 1 commit into from
Apr 20, 2019

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented Apr 20, 2019

The existing test results are too fragile to add new specs;

  1. The snapshot of the first test affects the second one, the second affects the third, and so on.
  2. The snapshot requires to be updated whenever the coverage of c8 itself changes.

This patch makes each test independent, by setting different --temp-directory flag to every spawnSync().

Checklist
  • npm test, tests passing
  • npm run test:snap (to update the snapshot)

The existing test results are too fragile to add new specs... the snapshot of the first test affects the second one, the second affects the third, and so on.
@coveralls
Copy link

coveralls commented Apr 20, 2019

Pull Request Test Coverage Report for Build 161

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.852%

Totals Coverage Status
Change from base Build 153: 0.0%
Covered Lines: 391
Relevant Lines: 401

💛 - Coveralls

@bcoe bcoe merged commit 51a9fa7 into master Apr 20, 2019
@bcoe bcoe deleted the fix-test-fragility branch April 20, 2019 23:45
mcknasty pushed a commit to mcknasty/c8 that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants