Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIDP-762 update college ux to match mockups #567

Merged

Conversation

kakarlavinodkumar
Copy link
Collaborator

college ux updated to match the mockups.

@kakarlavinodkumar kakarlavinodkumar added the DO NOT MERGE Definitely don't merge this PR! label Jul 12, 2024
@kakarlavinodkumar kakarlavinodkumar added Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing and removed DO NOT MERGE Definitely don't merge this PR! labels Jul 13, 2024
@Paahn
Copy link
Collaborator

Paahn commented Jul 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kakarlavinodkumar can you address these?

Copy link
Collaborator

@Paahn Paahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in laptop and desktop views, I would remove the height property on the card-styles class for viewport-all. this is the difference

before
before

after
after

@Paahn Paahn changed the title Feature/pidp 762 update college ux to match mockups PIDP-762 update college ux to match mockups Jul 30, 2024
@Paahn
Copy link
Collaborator

Paahn commented Aug 1, 2024

We can remove the breadcrumb from this PR as it is added as part of this PR

@Paahn Paahn self-requested a review August 2, 2024 16:26
Copy link
Collaborator

@Paahn Paahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the first time user submits their college licence and it is found, we get double breadcrumb on the top of the screen double breadcrumb

@Paahn Paahn self-requested a review August 7, 2024 18:52
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link
Collaborator

@Paahn Paahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakarlavinodkumar kakarlavinodkumar merged commit 2827ca2 into develop Aug 7, 2024
12 checks passed
@kakarlavinodkumar kakarlavinodkumar deleted the feature/pidp-762-update-college-ux-to-match-mockups branch August 7, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants