Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCProvider updates #566

Merged
merged 12 commits into from
Jul 17, 2024
Merged

BCProvider updates #566

merged 12 commits into from
Jul 17, 2024

Conversation

Paahn
Copy link
Collaborator

@Paahn Paahn commented Jul 11, 2024

  • FIxed form error text spacing in some views in mobile and tablet
    error text crashing into button

  • Fixed error message appearing when intializing the page

  • Added ngSrc to <img>

  • Fixed console warnings about loading the image source and zero height for image container

  • Fixed overflowing username in smaller screens

@Paahn Paahn self-assigned this Jul 11, 2024
@Paahn Paahn added the Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing label Jul 11, 2024
Copy link

sonarcloud bot commented Jul 17, 2024

Copy link
Collaborator

@AdityaMantripragada AdityaMantripragada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Paahn Paahn merged commit 3458192 into develop Jul 17, 2024
12 checks passed
@Paahn Paahn deleted the fix/bcprovider-visual-fixes branch July 17, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants