Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfiles #451

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Update Dockerfiles #451

merged 3 commits into from
Jan 4, 2024

Conversation

Paahn
Copy link
Collaborator

@Paahn Paahn commented Dec 11, 2023

  • Remove Endorsement reminder from local development as it is not needed locally
  • Specify version of Entity Framework as Docker was trying to run install ef version 8

@Paahn Paahn self-assigned this Dec 11, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

james-hollinger
james-hollinger approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@james-hollinger james-hollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Paahn Paahn merged commit be10b88 into develop Jan 4, 2024
7 of 8 checks passed
@Paahn Paahn deleted the feature/update-dockerfiles branch January 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-hollinger james-hollinger james-hollinger approved these changes

@bashbang bashbang Awaiting requested review from bashbang

Assignees

@Paahn Paahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paahn @james-hollinger