-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIDP-637 - init commit for dev helm deploys #260
Conversation
…mp stanza to trigger deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
helm list --namespace d8a8f9-dev | ||
|
||
echo installing helm chart... | ||
helm upgrade --install --wait --values ./deploy/dev_values.yaml --namespace d8a8f9-dev dev charts/pidp --debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helm upgrade --install --wait --values ./deploy/dev_values.yaml --namespace d8a8f9-dev dev charts/pidp --debug
suggestions:
- pull the "--debug"
- in "d8a8f9-dev dev charts/pidp". the "dev" is the name of the deployment. Since you're deploying several helm charts you should be sure to give this a unique name in the namespace. eg: dev-frontend This applies to each of the helm executions
push: | ||
branches: [develop] | ||
paths: | ||
- "charts/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding this as well: /deploy/dev_values.yaml
push: | ||
branches: [main] | ||
paths: | ||
- "charts/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding: ./deploy/prod_values.yaml
push: | ||
branches: [test] | ||
paths: | ||
- "charts/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding: ./deploy/test_values.yaml
No description provided.