Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIDP-637 - init commit for dev helm deploys #260

Merged
merged 43 commits into from
Jul 12, 2023
Merged

PIDP-637 - init commit for dev helm deploys #260

merged 43 commits into from
Jul 12, 2023

Conversation

wilson496
Copy link

No description provided.

wilson496 added 30 commits July 6, 2023 15:05
@wilson496 wilson496 requested a review from bashbang July 11, 2023 22:26
@wilson496 wilson496 added DO NOT MERGE Definitely don't merge this PR! DevOps labels Jul 11, 2023
Copy link
Collaborator

@bashbang bashbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

helm list --namespace d8a8f9-dev

echo installing helm chart...
helm upgrade --install --wait --values ./deploy/dev_values.yaml --namespace d8a8f9-dev dev charts/pidp --debug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm upgrade --install --wait --values ./deploy/dev_values.yaml --namespace d8a8f9-dev dev charts/pidp --debug

suggestions:

  1. pull the "--debug"
  2. in "d8a8f9-dev dev charts/pidp". the "dev" is the name of the deployment. Since you're deploying several helm charts you should be sure to give this a unique name in the namespace. eg: dev-frontend This applies to each of the helm executions

push:
branches: [develop]
paths:
- "charts/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding this as well: /deploy/dev_values.yaml

push:
branches: [main]
paths:
- "charts/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding: ./deploy/prod_values.yaml

push:
branches: [test]
paths:
- "charts/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding: ./deploy/test_values.yaml

@wilson496 wilson496 merged commit 5826114 into develop Jul 12, 2023
@wilson496 wilson496 deleted the PIDP-637 branch July 12, 2023 23:17
@wilson496 wilson496 restored the PIDP-637 branch July 13, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps DO NOT MERGE Definitely don't merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants