Code improvements for PR.

bcgov · Jul 13, 2024 · 0bbba23 · 0bbba23
1 parent 06c9aba
commit 0bbba23
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 80 deletions.
diff --git a/...e/pages/college-licence/college-licence-declaration/college-licence-declaration.page.html b/...e/pages/college-licence/college-licence-declaration/college-licence-declaration.page.html
@@ -24,8 +24,7 @@ <h3 class="college-licence">College licence information</h3>
           <mat-label class="field-label">College Licence</mat-label>
           <mat-select
             formControlName="collegeCode"
-            aria-labelledby="college-licence-declaration-college-licence"
-            [disabled]="disableCollegeCode">
+            aria-labelledby="college-licence-declaration-college-licence">
             <mat-option [value]="0">None</mat-option>
             <mat-option *ngFor="let college of colleges" [value]="college.code">
               {{ college.name }}
@@ -49,8 +48,7 @@ <h3 class="college-licence">College licence information</h3>
           <input
             matInput
             formControlName="licenceNumber"
-            aria-labelledby="college-licence-declaration-licence-number"
-            [disabled]="disableCollegeLicenceNumber"/>
+            aria-labelledby="college-licence-declaration-licence-number"/>
           <mat-error>Required</mat-error>
           <mat-hint>
             Example would be a 5 digit code

diff --git a/...ile/pages/college-licence/college-licence-declaration/college-licence-declaration.page.ts b/...ile/pages/college-licence/college-licence-declaration/college-licence-declaration.page.ts
@@ -38,7 +38,6 @@ import { CollegeLookup } from '@app/modules/lookup/lookup.types';
 import { CollegeLicenceDeclarationFormState } from './college-licence-declaration-form-state';
 import { CollegeLicenceDeclarationResource } from './college-licence-declaration-resource.service';
 import { PartyLicenceDeclarationInformation } from './party-licence-declaration-information.model';
-import { CollegeLicenceInformationPage } from '../college-licence-information/college-licence-information.page';
 
 @Component({
   selector: 'app-college-licence-declaration',
@@ -59,7 +58,6 @@ import { CollegeLicenceInformationPage } from '../college-licence-information/co
     NgIf,
     PageFooterActionDirective,
     ReactiveFormsModule,
-    CollegeLicenceInformationPage
   ],
 })
 export class CollegeLicenceDeclarationPage
@@ -74,7 +72,6 @@ export class CollegeLicenceDeclarationPage
   public colleges: CollegeLookup[];
   public showOverlayOnSubmit = true;
   public licenceDeclarationFailed = false;
-  public disableLiceNumber = true;
 
   public get showNurseValidationInfo(): boolean {
     const isNurse =

diff --git a/...e/pages/college-licence/college-licence-information/college-licence-information.page.scss b/...e/pages/college-licence/college-licence-information/college-licence-information.page.scss
@@ -38,16 +38,7 @@ $darkgrey: pidp.$bcgov-color-text;
     line-height: 27px;
     word-wrap: break-word;
   }
-  & .licences-box {
-    & .licences-licence-box {
-      border: solid 1px $darkgrey;
-      border-radius: 4px;
-      & .licence-icon-box {
-        background-color: $lightgrey;
-        border-radius: 4px;
-      }
-    }
-  }
+
   & .actions {
     margin-top: 20px;
     margin-bottom: 4rem;
@@ -60,7 +51,6 @@ $darkgrey: pidp.$bcgov-color-text;
   }
   padding: 1.25rem 0.75rem;
 
-
   .card-header-icon {
     display: flex;
     justify-content: space-between;
@@ -89,6 +79,15 @@ $darkgrey: pidp.$bcgov-color-text;
     flex-direction: column;
     gap: 20px;
 
+    & .licences-licence-box {
+      border: solid 1px $darkgrey;
+      border-radius: 4px;
+      & .licence-icon-box {
+        background-color: $lightgrey;
+        border-radius: 4px;
+      }
+    }
+
     & .card-styles {
       border-radius: 1.25rem;
       border: 1px solid #ccc;
@@ -167,30 +166,6 @@ $darkgrey: pidp.$bcgov-color-text;
       margin-bottom: 6px;
     }
   }
-  & .licences-box {
-    display: flex;
-    flex-direction: column;
-    gap: 20px;
-
-    & .card-styles {
-      border-radius: 1.25rem;
-      border: 1px solid #ccc;
-      background: #fff;
-      box-shadow: 0px 4px 4px 0px rgba(0, 0, 0, 0.25);
-      width: 37rem;
-      height: 11.875rem;
-      padding: 1.25rem;
-
-      h2 {
-        color: #036;
-        font-size: 1.5rem;
-        font-weight: 700;
-        padding-top: 0.25rem;
-        margin-bottom: 0;
-      }
-
-    }
-  }
 
   & .licence-detail-content {
     flex: 1;
@@ -199,28 +174,6 @@ $darkgrey: pidp.$bcgov-color-text;
     grid-gap: 3px;
   }
 
-  .card-header-icon {
-    display: flex;
-    justify-content: space-between;
-    align-items: center;
-    .lock-icon {
-      cursor: pointer;
-    }
-    .card-icon {
-      display: flex;
-      border-radius: 0.625rem;
-      border: 1px solid rgba(0, 51, 102, 0.2);
-      width: 2.5rem;
-      height: 2.5rem;
-      justify-content: center;
-      align-items: center;
-    }
-
-    img {
-      width: 1.5rem;
-      height: 1.5rem;
-    }
-  }
 }
 
 .viewport-small {
@@ -293,27 +246,11 @@ $darkgrey: pidp.$bcgov-color-text;
 
   & .card-styles {
     padding: 1rem;
-    // max-width: 400px;
     width: auto !important;
     height:21rem !important;
     h2 {
       font-size: 1.25rem;
     }
-
-    p {
-      font-size: 0.8rem;
-      line-height: 1.8;
-    }
-
-    a {
-      font-size: 0.9rem;
-    }
-
-    .linked-success {
-      span {
-        font-size: 14px;
-      }
-    }
   }
 
   & .actions {