Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

Create an uninstaller and updater, add support for ARM64/AARCH64 update readme and rename MAIN.sh to main.sh #6

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Lloir
Copy link

@Lloir Lloir commented Sep 23, 2020

No description provided.

@bc1bb bc1bb added the enhancement New feature or request label Sep 24, 2020
@bc1bb bc1bb self-requested a review September 24, 2020 10:17
Copy link
Owner

@bc1bb bc1bb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for that late reply,
Please look at the comments for each files and thanks a lot of your pull requests but it requires some changes to be better

systemctl daemon-reload
# remove systemd service

cp /etc/sudoers.beforewebra1n /etc/sudoers || fatal "Couldn't use /etc/sudoers backup"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatal() is a function I created in the original, as it's declared not in this file, calling it like this won't work.
Also crashing an uninstaller for such a reason doesnt seem a good idea to me

else
fatal "Looks like we can't download checkra1n for you architecture ($arch)"
fi

fi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add a fi

@@ -16,10 +16,13 @@ arch=$(uname -m)

if [ "$(echo "$links" | grep "$arch")" ]; then
link=$(echo "$links" | grep "$arch")
else
if arch=aarch64 ; then
arch=arm64
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but I would prefer the whole script written in the same way, this might look better and more readable:

if [ "$arch" = "aarch64" ]; then
  arch="arm64"


## To be done
- [~~Checkra1n Downloader~~ ✅](/checkra1n-downloader/checkra1n-downloader.sh)
- [~~Webra1n Service file~~ ✅](/webra1n.service)
- Access point creator
- [~~user creator for using `checkra1n` over SSH instead of HTTP~~ ✅](/MAIN.sh)
- Raspberry Pi image
- [~~Raspberry Pi image~~ ✅ ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it done ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants