Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysroot environment variable & flag to disable it #53

Closed
wants to merge 1 commit into from
Closed

Add sysroot environment variable & flag to disable it #53

wants to merge 1 commit into from

Conversation

mkpowers
Copy link
Contributor

This resolves issue #52 and allows cargo ndk build to build crates that use bindgen.

@bbqsrc
Copy link
Owner

bbqsrc commented Feb 9, 2022

I would prefer these flags to be opt-in, not opt-out. Can you change it to use the long flag --bindgen?

@x3ro
Copy link
Contributor

x3ro commented Mar 2, 2022

Hey folks. We're currently using a fork because of this issue, but would happily go back to upstream if it could get merged. If @mkpowers does not have the time, I'd also be happy to make an adjusted PR :)

@bbqsrc
Copy link
Owner

bbqsrc commented Mar 2, 2022

Please do. 🙂

@x3ro x3ro mentioned this pull request Mar 9, 2022
Merged
x3ro added a commit to x3ro/cargo-ndk that referenced this pull request Mar 9, 2022
@x3ro @mkpowers
Add ability to pass sysroot setting when building w/ bindgen
28283cc 
* Allows `cargo ndk build` to build crates that use bindgen

Fixes bbqsrc#52
Closes bbqsrc#53

Co-authored-by: Mackenzie Powers <mackenzie@junelife.com>
@bbqsrc bbqsrc closed this in 0cd72ec Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkpowers @bbqsrc @x3ro