Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use llvm-strip and llvm-ar if the arch-specific-named strip and ar are not present #41

Closed
wants to merge 2 commits into from

Conversation

codyps
Copy link

@codyps codyps commented Nov 16, 2021

Should fix #38

@bbqsrc
Copy link
Owner

bbqsrc commented Nov 17, 2021

Thanks for the contribution. I wonder if we should now also check if the new path exists as well, and if neither do, return an error?

@codyps
Copy link
Author

codyps commented Nov 17, 2021

We could, however:

  • for ar: making it a hard error here (where we're choosing to define some env vars), might take something that wouldn't be an issue (say, if the build happens to not require ar for some reason) and turn it into a hard error, leading folks to need to write workarounds (like creating a fake ar, or making some symlinks)
  • for strip: it seems like we could do this. Though I believe trying to run the command would provide us with a descriptive error (one we need to handle well anyhow)

@bbqsrc
Copy link
Owner

bbqsrc commented Nov 17, 2021

If someone doesn't need ar, cargo-ndk incidentally working isn't ideal, since it's not going to be a valid NDK in any case if it can't find all the basic pieces from the NDK. I prefer things to break when the environment is proven to not be coherent than accidentally work, had that happen to me enough times to become deeply sad. 😄

@bbqsrc bbqsrc closed this Feb 9, 2022
@harryfei
Copy link

Why this closed? We need this PR to work with the new version NDK.

@bbqsrc
Copy link
Owner

bbqsrc commented Mar 14, 2022

This is closed for the reasons clearly stated in my previous comment. If someone wants to make a PR that achieves the goals of this PR without causing the issues it causes, it will be merged.

Repository owner locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NDK 23 missing *-ar tools
3 participants