Add stderr text to exception thrown when ffmpeg invocation fails #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how we would/should add tests for this - mock the ffmpeg binary maybe? |
stephenjolly
force-pushed
the
report-ffmpeg-errors
branch
from
a596148
to
2c930c2
Compare
|
I added a test to cause ffmpeg to generate a file not found error. I also reduced the log level from "panic" to "error" based on https://ffmpeg.org/ffmpeg.html#toc-Generic-options, which says "panic" isn't currently used. |
chrisn
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local testing on a machine with a faulty ffmpeg installation resulted in an ffmpeg invocation failure, which revealed that the current code suppresses ffmpeg output, preventing debugging. This PR captures stderr when invoking ffmpeg and adds it to the exception thrown when ffmpeg invocation fails.