Fix some incompatible native android_* rules references #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgruber
requested review from
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
cgruber
force-pushed
the
fix/incompatible_native_android_rules
branch
from
cb9de66
to
ed865a2
Compare
This only fixes these references within the library, and does not address third-party violations from things like @build_tools. Fix up and reorganize workspace file
cgruber
force-pushed
the
fix/incompatible_native_android_rules
branch
from
ed865a2
to
03fb81d
Compare
cgruber
changed the title
|
crap - this change adds a real dependency on the android rules which, if you don't use android, bleeds into your project if you use the kotlin rules. I think this actually needs a bit of a project reorganization so it doesn't require the android stuff to be present in the midst of the non-android stuff. :/ (Thanks, CI, for pointing this out) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only fixes these references within the library, and does not address third-party violations from things like @build_tools. Also, updates and reorganizes the android sample's WORKSPACE file. Minor buildifier formatting also.
Partly addresses #251