Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run nogo in a separate validation action #3995

Merged
merged 32 commits into from
Aug 6, 2024
Merged

Run nogo in a separate validation action #3995

merged 32 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. Register generated cgo Go sources as outputs

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d4dbece View commit details
    Browse the repository at this point in the history

  2. Extract nogo

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    954c098 View commit details
    Browse the repository at this point in the history

  3. Remove old nogo logic

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0dc29a9 View commit details
    Browse the repository at this point in the history

  4. Always produce facts

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    76eaa03 View commit details
    Browse the repository at this point in the history

  5. Refactor out file definitions

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    47d0190 View commit details
    Browse the repository at this point in the history

  6. Fix buildifier

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9ca56a1 View commit details
    Browse the repository at this point in the history

  7. Add recompile_internal_deps

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    eb1dbbc View commit details
    Browse the repository at this point in the history

  8. Do not print output twice

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0aa2e17 View commit details
    Browse the repository at this point in the history

  9. Wire up cover_mode and cgo srcs

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e9b484e View commit details
    Browse the repository at this point in the history

  10. Wire up cover_archive

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    483afa1 View commit details
    Browse the repository at this point in the history

  11. Use a dedicated exit code for findings

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4ea34a2 View commit details
    Browse the repository at this point in the history

  12. Update custom_test.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3563e27 View commit details
    Browse the repository at this point in the history

  13. Update custom_test.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3063bfe View commit details
    Browse the repository at this point in the history

  14. Run cgo twice with coverage

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9c1c01c View commit details
    Browse the repository at this point in the history

  15. Add docs and register output for binary rules

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    62c42d4 View commit details
    Browse the repository at this point in the history

  16. Use a Go tool for validation

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b180314 View commit details
    Browse the repository at this point in the history

  17. Update go/tools/builders/nogo.go 

    Co-authored-by: Zhongpeng Lin <zplin@uber.com>
    @fmeum @linzhp
    fmeum and linzhp committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    55804d6 View commit details
    Browse the repository at this point in the history

  18. Update go/tools/builders/nogo.go 

    Co-authored-by: Zhongpeng Lin <zplin@uber.com>
    @fmeum @linzhp
    fmeum and linzhp committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e858e2c View commit details
    Browse the repository at this point in the history

  19. Address more comments

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3cf2ee0 View commit details
    Browse the repository at this point in the history

  20. Use exit code

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9ec89eb View commit details
    Browse the repository at this point in the history

  21. Update constants.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e2ea091 View commit details
    Browse the repository at this point in the history

  22. Update nogo.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d2c0599 View commit details
    Browse the repository at this point in the history

  23. Update nogo_main.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4460988 View commit details
    Browse the repository at this point in the history

  24. Update nogo_validation.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ca62338 View commit details
    Browse the repository at this point in the history

  25. Update nogo_validation.go

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8f311d6 View commit details
    Browse the repository at this point in the history

  26. Rename constants

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    fc8bbfb View commit details
    Browse the repository at this point in the history

  27. Add comments

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6436295 View commit details
    Browse the repository at this point in the history

  28. Fix output of nogovalidation

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    62ef390 View commit details
    Browse the repository at this point in the history

  29. Fix output of nogovalidation

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    89b22b5 View commit details
    Browse the repository at this point in the history

  30. Fix out of date info on nogo configuration

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cfbf986 View commit details
    Browse the repository at this point in the history

  31. Optionally let nogo itself fail on findings

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7bb2d8a View commit details
    Browse the repository at this point in the history

  32. Also fix 3846

    @fmeum
    fmeum committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ddb181b View commit details
    Browse the repository at this point in the history