Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle long filenames on Windows in a few more places. #2781

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Handle long filenames on Windows in a few more places. #2781

merged 1 commit into from
Jan 11, 2021

Conversation

pmuetschard
Copy link
Contributor

C.f. #1382

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
Makes rules_go work on Windows with long filenames.

@google-cla google-cla bot added the cla: yes label Jan 11, 2021
jayconrod
jayconrod approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@jayconrod jayconrod merged commit c403e77 into bazelbuild:master Jan 11, 2021
@pmuetschard pmuetschard deleted the win_fix branch January 12, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayconrod jayconrod jayconrod approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmuetschard @jayconrod