Clarify that servers should extend TLL for blobs referenced in FindMissingBlobs #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(ContentAddressableStorage.FindMissingBlobs): Clarify that servers should extend lifetime for blobs requested.
sstriker
requested review from
agoulti,
bergsieker,
buchgr,
ola-rozenfeld and
ulfjack
as code owners
googlebot
added
the
cla: yes
mostynb
reviewed
Jan 22, 2020
| @@ -246,6 +246,9 @@ service ContentAddressableStorage { | |||
| // Clients can use this API before uploading blobs to determine which ones are | |||
| // already present in the CAS and do not need to be uploaded again. | |||
| // | |||
| // Servers SHOULD increase the TTLs of the referenced blobs if necessary and | |||
There was a problem hiding this comment.
nitpick: "TTL" sounds like an implementation detail. Would it make sense to change "TTLs" to "lifetimes" (both here and the GetActionResult comment that already exists in this doc)?
There was a problem hiding this comment.
GetActionResult seems to use TTLs? Generally I agree that we should standardize on one wording. I don't have a preference either way.
There was a problem hiding this comment.
Can we fix terminology in a separate PR? I would prefer to get the intent across regardless :).
There was a problem hiding this comment.
Yes, of course. This is just a "nitpick".
There was a problem hiding this comment.
I prefer "lifetime" to "TTL" but agree that the terminology change can be made separately
bergsieker
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ContentAddressableStorage.FindMissingBlobs): Clarify that servers
should extend lifetime for blobs requested.