Add java home to the blaze info #6810
Open
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-mcnamara
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
3 tasks
brian-mcnamara
force-pushed
the
javaHome
branch
from
3f92062
to
6db438f
Compare
|
It took me a bit of digging to chase all the mock setters. Not all the extensions use the Mock bits from the Mocked provider. I forgot exactly the bits but they might be visible in the old PR |
brian-mcnamara
force-pushed
the
javaHome
branch
from
6db438f
to
550db07
Compare
Thanks, did take a few trial and error, I should have looked at your pr :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Related to
Description of this change
Related to #6728. We were relying on the info cache to have java home that bazel uses. After that change the value is no longer provided causing issues on our extension plugin.