Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedded go_source rule type in go_test and go_library rules #5205

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Support embedded go_source rule type in go_test and go_library rules #5205

merged 2 commits into from
Aug 22, 2023

Conversation

lbcjbb
Copy link
Contributor

@lbcjbb lbcjbb commented Aug 6, 2023

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked.
See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: #1265

Description of this change

This change mark all source files and generated source files of all embedded go_source rules in go_test and go_library rules as source files.

@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Aug 6, 2023
@lbcjbb lbcjbb mentioned this pull request Aug 6, 2023
Closed
@sgowroji sgowroji added the lang: go Go rules integration label Aug 7, 2023
blorente
blorente approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Would you be open to extending the example project (examples/go/with_proto) with a go_source before merging this?

@lbcjbb
Copy link
Contributor Author

lbcjbb commented Aug 21, 2023

It's done. Thank you @blorente

blorente
blorente approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it fixes the problem. Thanks for the contribution! Just a small fix on the project view file and we can merge.

examples/go/with_go_source/with_go_source.bazelproject Show resolved Hide resolved
@blorente blorente merged commit d7e465c into bazelbuild:master Aug 22, 2023
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 22, 2023
@lbcjbb lbcjbb deleted the feature/go_source-support branch August 22, 2023 11:35
@mai93 mai93 mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blorente blorente blorente approved these changes

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner

@jastice jastice Awaiting requested review from jastice

@tpasternak tpasternak Awaiting requested review from tpasternak tpasternak is a code owner

Assignees

@blorente blorente

Labels
lang: go Go rules integration
Projects
Bazel IntelliJ Plugin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbcjbb @blorente @sgowroji