Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the versions of rules_scala and rules_kotlin to the latest commits #485

Closed
wants to merge 1 commit into from

Conversation

vladmos
Copy link
Member

@vladmos vladmos commented Jan 7, 2019

The currently used versions contain the deprecated cfg = "data" configuration which will not be compatible with the next version of Bazel.

@laurentlb
Copy link

This should fix #482

@meteorcloudy
Copy link
Member

I heard @buchgr has write access to everything under bazelbuild ;)

@laurentlb
Copy link

This repository is synced with Google depot. I'd prefer to hear from an owner (cc @brendandouglas) before escalating to a bazelbuild admin.

@meteorcloudy
Copy link
Member

Ah, make sense!

@brendandouglas
Copy link
Contributor

Thanks for the PR, I've applied it upstream (we don't make changes to this repo directly).

I'll merge the pending PR from upstream when the CI is passing -- looks like it's currently failing due to an old version of the protobuf library using REPOSITORY_NAME.

I'll update that library, and close #482 once the CI is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants