Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let --bisect=~<old>..<new> find the first fixing commit #613

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Sep 19, 2024

No description provided.

@fmeum
Copy link
Contributor Author

fmeum commented Sep 19, 2024

@meteorcloudy

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for implementing this with such a simple syntax!

README.md Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
@fmeum
Copy link
Contributor Author

fmeum commented Sep 19, 2024

@meteorcloudy Updated the PR. I started out with !, but then noticed that it is a special shell character that would have made it hard to use.

@meteorcloudy meteorcloudy merged commit bb3bb3f into bazelbuild:master Sep 19, 2024
2 checks passed
@fmeum fmeum deleted the negate-bisect branch September 19, 2024 13:03
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
##### [`v1.22.0](https://github.com/bazelbuild/bazelisk/releases/tag/v1.22.0)

Bazelisk v1.22.0 comes with several significant changes:

### New Features (Go)

-   Bazelisk sets the `BAZELISK` env variable so that scripts can detect whether they're running under Bazelisk (bazelbuild/bazelisk#612)
-   `--bisect` now supports finding the first *fixing* commit by prefixing the range with `~` (bazelbuild/bazelisk#613)

### Removed Features (Go)

-   Removed support for `last_downstream_green` since the downstream pipeline stopped producing green commits some time ago.

### Bug Fixes & Improvements

-   Improved `last_green` support (bazelbuild/bazelisk#614)

We’d like to thank our amazing contributors [@fmeum](https://github.com/fmeum) and [@jwnimmer-tri](https://github.com/jwnimmer-tri)!
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
##### [`v1.22.0](https://github.com/bazelbuild/bazelisk/releases/tag/v1.22.0)

Bazelisk v1.22.0 comes with several significant changes:

### New Features (Go)

-   Bazelisk sets the `BAZELISK` env variable so that scripts can detect whether they're running under Bazelisk (bazelbuild/bazelisk#612)
-   `--bisect` now supports finding the first *fixing* commit by prefixing the range with `~` (bazelbuild/bazelisk#613)

### Removed Features (Go)

-   Removed support for `last_downstream_green` since the downstream pipeline stopped producing green commits some time ago.

### Bug Fixes & Improvements

-   Improved `last_green` support (bazelbuild/bazelisk#614)

We’d like to thank our amazing contributors [@fmeum](https://github.com/fmeum) and [@jwnimmer-tri](https://github.com/jwnimmer-tri)!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants