Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure with --incompatible_disallow_empty_glob #198

Closed
shahms opened this issue Aug 29, 2023 · 0 comments · Fixed by #200
Closed

Failure with --incompatible_disallow_empty_glob #198

shahms opened this issue Aug 29, 2023 · 0 comments · Fixed by #200

Comments

@shahms
Copy link

shahms commented Aug 29, 2023

The data = glob(["testdata/**"]) in

rules_jvm/java/gazelle/BUILD.bazel

Line 50 in fae67e4

data = glob(["testdata/**"]),
is empty because the testdata subdirectory contains a BUILD.bazel file and globs don't cross package boundaries. This causes the build to fail when --incompatible_disallow_empty_glob is set.

This will eventually become the default (tracked in bazelbuild/bazel#8195 )
illicitonion added a commit to illicitonion/rules_jvm that referenced this issue Aug 31, 2023
@illicitonion
Remove empty glob
7835e89 
This directory is a package.

Fixes bazel-contrib#198.
@illicitonion illicitonion mentioned this issue Aug 31, 2023
Merged
illicitonion added a commit to illicitonion/rules_jvm that referenced this issue Sep 4, 2023
@illicitonion
Remove empty glob
4d5b0ad 
This directory is a package.

Fixes bazel-contrib#198.
illicitonion added a commit that referenced this issue Sep 5, 2023
@illicitonion
Remove empty glob (#200)
e3e26fb 
This directory is a package.

Fixes #198.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty glob illicitonion/rules_jvm
1 participant
@shahms