Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor for mingw, data type tweaks, and warning removal. #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Minor refactor for mingw, data type tweaks, and warning removal. #5

wants to merge 6 commits into from

Conversation

SolomonSklash
Copy link

I made a few minor tweaks to better support mingw and to reduce compiler warnings:

  • Added function signatures to corresponding header files to remove no previous declaration for warnings.
  • A new header darkmodule.h was created to contain the _DARKMODULE struct definition. This is so that darkloadlibrary.h can include each of the other headers with their new function signatures.
  • A couple variables were PCHARs instead of PWCHARs.

hypervis0r
hypervis0r approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@hypervis0r hypervis0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this unicode string bug needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypervis0r hypervis0r hypervis0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SolomonSklash @hypervis0r