Fix bug in evaluation for tie in scores. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhshkdz
reviewed
Jul 26, 2018
utils.lua
Outdated
| ranks = ranks:view(-1, numOpts) | ||
| local gtRanks = torch.LongTensor(gtPos:size(1)) | ||
| for i = 1, gtPos:size(1) do | ||
| gtBinary = torch.LongTensor(numOpts):zero() |
There was a problem hiding this comment.
gtBinary doesn't need to be a global variable, right?
abhshkdz
reviewed
Jul 26, 2018
utils.lua
Outdated
| for i = 1, gtPos:size(1) do | ||
| gtBinary = torch.LongTensor(numOpts):zero() | ||
| gtBinary[{gtPos[{i}]}] = 1 | ||
| sorted, rankedIdx = ranks[{i}]:sort() |
There was a problem hiding this comment.
Wait, can't we re-use rankedIdx from L108 instead of recomputing it again for every round?
abhshkdz
reviewed
Jul 26, 2018
utils.lua
Outdated
| gtBinary[{gtPos[{i}]}] = 1 | ||
| sorted, rankedIdx = ranks[{i}]:sort() | ||
| sortedGt = gtBinary:index(1, rankedIdx:long()) | ||
| gtRank = sortedGt:nonzero() |
There was a problem hiding this comment.
sortedGt and gtRank don't need to be global either.
kdexd
commented
Jul 26, 2018
utils.lua
Outdated
| sortedGt = gtBinary:index(1, rankedIdx:long()) | ||
| gtRank = sortedGt:nonzero() | ||
| gtRanks[i] = gtRank | ||
| gtRanks[i] = ranks[{i, gtPos[i]}] |
There was a problem hiding this comment.
Oh, I see how this works... I tried advanced indexing to avoid this loop (using multiple LongTensors) and when it raised errors about lack of support, it suffered over-simplification (straightaway as the EvalAI script does it).
I tested this to cross verify and it works fine too. We are good to go with it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the score of ground truth would tie with another option, it always got assigned a higher rank. This caused evaluation metrics to be reported higher than their true values. This PR fixes that.