Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause video to prevent mobile browser freezes onDestroy #106

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

JemiloII
Copy link
Contributor

No description provided.

@jmeinke
Copy link

jmeinke commented Feb 24, 2021

@basst314 Please merge this and release a new version!

@kishoreaoe
Copy link

@JemiloII , will this PR, solves in browser slowness when we load the video element multiples times, as this is happening because we are not destroying it completely on changing to new route.

@kishoreaoe
Copy link

@basst314 , kindly help in merging this PR, this is very much useful

@JemiloII
Copy link
Contributor Author

When the component is unloaded, the video is component is destroyed on its own. However, not stopping the video play while destroying the video element causes problems that ends up freezing the browser.

@kishoreaoe
Copy link

@JemiloII , any other workaround to implement the same, if new version is not released.

@basst314 basst314 merged commit 2c868bc into basst314:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants