Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to make clippy happy #128

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jondo2010
Copy link
Contributor

Our project Rerun uses pretty strict clippy settings, and I ran into several linting issues with the code generated by shadow-rs:

error: item in documentation is missing backticks
    --> /Users/john/Source/rerun/target/debug/build/rerun-5295388bed2c865d/out/shadow.rs:1254:67
     |
1254 | /// The common version const. It's so easy to use this const with CLAP_VERSION.
     |                                                                   ^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
     = note: `-D clippy::doc-markdown` implied by `-D warnings`

and

error: missing documentation for a module
  --> crates/rerun/src/lib.rs:94:1
   |
94 | shadow_rs::shadow!(build);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D missing-docs` implied by `-D warnings`

This PR fixes those lints.

@baoyachi baoyachi changed the base branch from master to fix_clippy February 16, 2023 01:39
@baoyachi baoyachi merged commit d4145c5 into baoyachi:fix_clippy Feb 16, 2023
@baoyachi
Copy link
Owner

@jondo2010 Thx. please use shadow-rs new version:

shadow-rs = "0.20.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants