Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: allow providing custom http.Client #23

Merged
merged 1 commit into from
Apr 14, 2023
Merged

refactor!: allow providing custom http.Client #23

merged 1 commit into from
Apr 14, 2023

Conversation

chrisgacsal
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
API breaks? yes
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Change client.Config to accept http.Client instead of http.Transport to provide more control over how HTTP communication is done via API client.

Checklist

  • Implementation tested
  • Tested against Cruise Control version: x.y.z (if applicable)
  • User guide and development docs updated (if needed)

@chrisgacsal chrisgacsal requested a review from a team as a code owner April 12, 2023 13:30
@chrisgacsal chrisgacsal self-assigned this Apr 12, 2023
@chrisgacsal chrisgacsal merged commit 104c0f4 into main Apr 14, 2023
@chrisgacsal chrisgacsal deleted the httpclient-from-config branch April 14, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@panyuenlau panyuenlau panyuenlau approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisgacsal @pregnor @panyuenlau