Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedy #133

Merged
merged 24 commits into from
Mar 9, 2023
Merged

Speedy #133

merged 24 commits into from
Mar 9, 2023

Conversation

organizedgrime
Copy link
Contributor

In this branch we diagnosed and addressed issues regarding performance. GZIP is now replaced by ZSTD, and duplication detection and file grouping are now outsources to fclones. As a result, we've drastically improved performance and are now packing files at ~1GiB/s.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 2.94% and project coverage change: +0.53 🎉

Comparison is base (02f3692) 5.06% compared to head (07550bf) 5.60%.

❗ Current head 07550bf differs from pull request most recent head eb3ed06. Consider uploading reports for the commit eb3ed06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #133      +/-   ##
=========================================
+ Coverage    5.06%   5.60%   +0.53%     
=========================================
  Files          15      13       -2     
  Lines         454     375      -79     
  Branches      454     375      -79     
=========================================
- Hits           23      21       -2     
+ Misses        431     354      -77     
Impacted Files Coverage Δ
...rc/do_pipeline_and_write_metadata/pack_pipeline.rs 0.00% <0.00%> (ø)
.../do_pipeline_and_write_metadata/unpack_pipeline.rs 0.00% <0.00%> (ø)
dataprep-lib/src/lib.rs 0.00% <0.00%> (ø)
dataprep-lib/src/spider.rs 0.00% <0.00%> (ø)
dataprep-lib/src/types/pack_plan.rs 0.00% <0.00%> (ø)
dataprep-lib/src/types/shared.rs 0.00% <0.00%> (ø)
dataprep-lib/src/types/spider.rs 0.00% <0.00%> (ø)
dataprep-lib/src/types/unpack_plan.rs 0.00% <0.00%> (ø)
dataprep-lib/src/utils/fs.rs 0.00% <ø> (ø)
dataprep-lib/src/vacuum/pack.rs 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@organizedgrime organizedgrime marked this pull request as ready for review March 7, 2023 14:38
@laudiacay laudiacay merged commit eb7088b into master Mar 9, 2023
@laudiacay laudiacay deleted the speedy branch March 9, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants