-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the function call to getAdminInfo() #505
base: main
Are you sure you want to change the base?
Conversation
…nction call to getAdminInfo() Commented to test the change 465
…ented code test the app, successfull 465
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @code-Gambler thank you very much for the PR 🙏 I was testing it locally and the API Key component in the dashboard does not work properly when I want to generate a new API Key. Does it work fine for you? |
My bad on approving this - I remember that the |
Hey @0xjei!
Yes, correct. Those functions were necessary to have the updated info. I think there could be a way to improve that code to prevent calling the API if the data is already in the frontend. |
yes, there can be some sort of optimization for sure :) |
Description
As the functions handleRefresh() and toggleIsEnabled() were calling the function getAdminInfo() unnecessarily despite of the information already being present in the frontend. So, removed the function call to getAdminInfo()
Ran the unit tests and tested the dashboard application as well.
Related Issue
#465
Does this introduce a breaking change?