fix(test): fix Operation not supported on socket #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flashlight-docs canceled.
|
Almouro
force-pushed
the
fix/exec-async
branch
from
31e0d1e
to
65cdf5c
Compare
We completely simplify the logic here. This brings us another fix: adding `&&` in `testCommand` now works (like `--testCommand "sleep 5 && adb shell am start com.example/.MainActivity" for instance) One caveat is we lose the nice Maestro formatting, but I think that's an acceptable loss, given that it was always clearing the terminal on each iteration anyway Now we have the same output as using `maestro` with `--no-ansi`
Almouro
force-pushed
the
fix/exec-async
branch
from
65cdf5c
to
7f3de8c
Compare
Flashlight iOS Report 🔦 |
Flashlight Automated Report 🔦 |
MaeIg
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Can reproduce the bug after upgrading to Sonoma 14.0, but somehow not before 🤔 haven't verified in dept, I prefered to completely simplify the logic here and that fixes the bug.
This brings us another fix: adding
&&intestCommandnow works (like `--testCommand "sleep 5 && adb shell am start com.example/.MainActivity" for instance)One caveat is we lose the nice Maestro formatting, but I think that's an acceptable loss, given that it was always clearing the terminal on each iteration anyway Now we have the same output as using
maestrowith--no-ansiThis is what it looks like now:
