Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiler): no such file /proc/{pid}/task #117

Merged
merged 13 commits into from
Jul 12, 2023
Merged

fix(profiler): no such file /proc/{pid}/task #117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dcfd7a7
fix(profiler): ensure failure if profiling script fails
Almouro Jun 2, 2023
e36ffc5
docs(cpp): update docs to run c++ profiler
Almouro Jun 26, 2023
994561a
refactor(cpp): move logic to function
Almouro Jun 26, 2023
c53428a
chore(cpp): throw custom error if directory not found
Almouro Jun 26, 2023
5749788
refactor: move some test utils to e2e folder
Almouro Jun 27, 2023
9e5327e
refactor(test): separate between atrace mock and profiler mock
Almouro Jul 3, 2023
c6bf617
refactor(test): fix some typings
Almouro Jul 3, 2023
3ebbd5a
refactor(profiler): add logStderr option
Almouro Jul 3, 2023
65d1a93
refactor(profiler): pass errors on stderr instead of stdout
Almouro Jul 3, 2023
08c09c0
fix(profiler): reset measures if pid changes
Almouro Jul 3, 2023
b75d0a1
chore(cpp): recompile executables
Almouro Jul 3, 2023
2cdc44b
fix(profiler): ensure graceful kill doesn't throw error
Almouro Jul 6, 2023
6ac2118
chore: fix comment
Almouro Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-performance/src/__tests__/measurePerformance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import os from "os";
import fs from "fs";
import { measurePerformance } from "..";
import { PerformancePollingMock } from "../utils/PerformancePollingMock";
import { PerformancePollingMock } from "../utils/test/PerformancePollingMock";
import { Logger, LogLevel } from "@perf-profiler/logger";

const mockPerformancePolling = new PerformancePollingMock();
Expand Down
0 ...mance/src/utils/PerformancePollingMock.ts → .../src/utils/test/PerformancePollingMock.ts
View file
Open in desktop
File renamed without changes.
0 ...e/src/__tests__/utils/mockChildProcess.ts → ...rmance/src/utils/test/mockChildProcess.ts
View file
Open in desktop
File renamed without changes.
6 changes: 4 additions & 2 deletions ...e/src/__tests__/utils/mockEmitMeasures.ts → ...rmance/src/utils/test/mockEmitMeasures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* eslint-disable @typescript-eslint/no-var-requires */
Copy link
Contributor

@legkikh legkikh Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes (but at least it's in a test file)

import EventEmitter from "events";
import { ChildProcess } from "child_process";

const mockSpawn = (): { stdout: EventEmitter; kill: () => void } => {
const mockProcess = new EventEmitter();
Expand All @@ -10,7 +12,7 @@ const mockSpawn = (): { stdout: EventEmitter; kill: () => void } => {
.spyOn(require("child_process"), "spawn")
.mockImplementationOnce((...args) => {
expect(args).toEqual(["adb", ["shell", "atrace", "-c", "view", "-t", "999"]]);
return mockProcess;
return mockProcess as ChildProcess;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with these casts I suppose ?

})
.mockImplementationOnce((...args) => {
expect(args).toEqual([
Expand All @@ -23,7 +25,7 @@ const mockSpawn = (): { stdout: EventEmitter; kill: () => void } => {
"500",
],
]);
return mockProcess;
return mockProcess as ChildProcess;
});

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Expand Down
0 .../__tests__/utils/sample-atrace-output.txt → ...e/src/utils/test/sample-atrace-output.txt
View file
Open in desktop
File renamed without changes.
0 ...tests__/utils/sample-command-output-1.txt → ...rc/utils/test/sample-command-output-1.txt
View file
Open in desktop
File renamed without changes.
0 ...tests__/utils/sample-command-output-2.txt → ...rc/utils/test/sample-command-output-2.txt
View file
Open in desktop
File renamed without changes.
0 ...__tests__/utils/sample-gfxinfo-output.txt → .../src/utils/test/sample-gfxinfo-output.txt
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions packages/flipper-plugin-android-performance-profiler/src/__tests__/Plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// We'll remove the flipper plugin at some point so it's ok to just import those
// from another package in the test
// eslint-disable-next-line import/no-extraneous-dependencies
import "@perf-profiler/measure/src/__tests__/utils/mockChildProcess";
import "@perf-profiler/e2e/src/utils/test/mockChildProcess";
// eslint-disable-next-line import/no-extraneous-dependencies
import { emitMeasures, spawn } from "@perf-profiler/measure/src/__tests__/utils/mockEmitMeasures";
import { emitMeasures, spawn } from "@perf-profiler/e2e/src/utils/test/mockEmitMeasures";
import { act, fireEvent, screen } from "@testing-library/react";
import { TestUtils } from "flipper-plugin";
import * as Plugin from "..";
Expand Down
4 changes: 2 additions & 2 deletions packages/measure/src/__tests__/measure.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import "./utils/mockChildProcess";
import { spawn, emitMeasures } from "./utils/mockEmitMeasures";
import "@perf-profiler/e2e/src/utils/test/mockChildProcess";
import { spawn, emitMeasures } from "@perf-profiler/e2e/src/utils/test/mockEmitMeasures";
import { fireEvent, render as webRender, screen, waitFor, act } from "@testing-library/react";
import { render as cliRender } from "ink-testing-library";
import { MeasureWebApp } from "../webapp/MeasureWebApp";
Expand Down