-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dims instead of coords #499
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
==========================================
- Coverage 90.47% 90.32% -0.16%
==========================================
Files 29 29
Lines 2320 2459 +139
==========================================
+ Hits 2099 2221 +122
- Misses 221 238 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Extract args (#493) * fix multinomial family with group-specific terms * Refactorize how we compute predictions * remove unintentional brms file and black * remove typo from test * rerun categorical regression * add shooter data again * Update coords of terms * Fixed stack order in predict for categorical group specific terms and message label in bernoulli family * [no ci] docstring * Add utils to extract labels when we use multinomial family. Also add 'c' function which was not added before. * Add coordinate for predictions in multinomial model * Use dims instead of coords (#499) * Update to use dims instead of coords. Also rename group-specific dims * update examples that used coords * Update changelog * Fix how we look for dims. This should fix tests * Fix typos (#501) * Don't modify original dataset (#502) * Don't modify original dataset * update changelog * black and lint * [no ci] update changelog * [no ci] minor updates to CONTRIBUTING * [no ci] update docs conf * Remove draws argument from model predict (#504) * Prepare 0.8.0 release (#505) * Prepare release (update formulae reqs) * Update changelog * Update publish-docs-release.yml * Update publish-docs-release.yml * Add workflow_dispatch to .yml to run manually * merge changes * update backend to PyMC v4 Co-authored-by: Tomás Capretto <tomicapretto@gmail.com> Co-authored-by: Hector Munoz <23343812+hectormz@users.noreply.github.com>
I realized we were using the term
coords
for things that are actuallydims
in thexarray
world.This PR updates several places where we were wrongly using
coords
.On top of that, I renamed the dimensions we use for group-specific terms:
factor + "_coord_group_factor"
is nowfactor + "__factor_dim"
expr + "_coord_group_expr"
is nowexpr + "__expr_dim"
which are clearer, shorter, and safer.