Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connector build failure in Windows #143

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Jun 26, 2024

Purpose

$subject

Fixes: #6664

Following are the findings related to this issue:

  • When running the build, the docker command fails silently and due to that FileNotFoundException is thrown when the plugin tries to extract the package bala
  • The docker command failure was due to having invalid environment variables in the docker.env file

Following improvements should be done to the plugin to fix this:

  • Log the docker command failure as an error in the console
  • Exclude the not-required environment variables from the docker.env file

@ayeshLK ayeshLK marked this pull request as draft June 26, 2024 09:25
@ayeshLK ayeshLK marked this pull request as ready for review June 26, 2024 09:33
@ayeshLK ayeshLK merged commit 773102a into ballerina-platform:main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector builds are failing in windows
3 participants