Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextually expected type inference support for client methods #396

Merged
merged 4 commits into from
May 17, 2021

Conversation

chamil321
Copy link
Contributor

@chamil321 chamil321 commented May 17, 2021

Purpose

Fixes ballerina-platform/ballerina-library#1371

Examples

json j = check clientEndpoint->post("/test", request);

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #396 (0f0ef0c) into master (5bb56a7) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
- Coverage     76.89%   76.86%   -0.04%     
  Complexity       62       62              
============================================
  Files           319      319              
  Lines         16258    16258              
  Branches       3735     3735              
============================================
- Hits          12501    12496       -5     
- Misses         3044     3048       +4     
- Partials        713      714       +1     
Impacted Files Coverage Δ Complexity Δ
http-ballerina/resiliency_failover_client.bal 82.55% <37.50%> (-0.68%) 0.00 <0.00> (ø)
http-ballerina/resiliency_load_balance_client.bal 89.22% <50.00%> (-0.60%) 0.00 <0.00> (ø)
http-ballerina/http_client_endpoint.bal 85.76% <100.00%> (ø) 0.00 <0.00> (ø)
http-ballerina/http_client_object.bal 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...sport/message/ClientRemoteFlowControlListener.java 52.63% <0.00%> (-15.79%) 0.00% <0.00%> (ø%)
...ansport/message/DefaultBackPressureObservable.java 64.28% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...tractimpl/sender/ConnectionAvailabilityFuture.java 70.73% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)
...alang/net/http/service/signature/ParamHandler.java 86.02% <0.00%> (-1.48%) 0.00% <0.00%> (ø%)
...nsport/contractimpl/DefaultHttpResponseFuture.java 77.27% <0.00%> (+3.89%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb56a7...0f0ef0c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contextually expected type inference support for client remote methods
2 participants