Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate workflows to reuse workflows from ballerina-standard-library repo #724

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Migrate workflows to reuse workflows from ballerina-standard-library repo #724

merged 8 commits into from
Oct 12, 2023

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Oct 9, 2023

Purpose

$subject

Part of: #4778

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@ayeshLK ayeshLK marked this pull request as draft October 9, 2023 05:20
@ayeshLK ayeshLK marked this pull request as ready for review October 9, 2023 05:23
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d45200) 81.36% compared to head (fcc2498) 81.36%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #724   +/-   ##
=========================================
  Coverage     81.36%   81.36%           
  Complexity      161      161           
=========================================
  Files            22       22           
  Lines          1057     1057           
  Branches        206      206           
=========================================
  Hits            860      860           
  Misses          114      114           
  Partials         83       83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayeshLK ayeshLK mentioned this pull request Oct 9, 2023
Closed
NipunaRanasinghe
NipunaRanasinghe approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion

.github/workflows/central-publish.yml Outdated
secrets: inherit
with:
environment: ${{ github.event.inputs.environment }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional blank line

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MohamedSabthar MohamedSabthar merged commit 9222f70 into ballerina-platform:master Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

@Maninda Maninda Awaiting requested review from Maninda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayeshLK @NipunaRanasinghe @MohamedSabthar