Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support union type for XMl data module #43

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

SasinduDilshara
Copy link
Contributor

@SasinduDilshara SasinduDilshara commented Aug 22, 2024

Support union type for XMl data module

fixes ballerina-platform/ballerina-library#6596

@SasinduDilshara SasinduDilshara marked this pull request as draft August 22, 2024 08:46
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 79.38931% with 54 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (a32e34e) to head (543b0a6).
Report is 19 commits behind head on main.

Files Patch % Lines
...io/ballerina/lib/data/xmldata/utils/DataUtils.java 79.54% 20 Missing and 7 partials ⚠️
...o/ballerina/lib/data/xmldata/xml/XmlTraversal.java 80.00% 13 Missing and 7 partials ⚠️
...llerina/lib/data/xmldata/xml/QualifiedNameMap.java 0.00% 5 Missing ⚠️
.../xmldata/compiler/XmldataRecordFieldValidator.java 83.33% 0 Missing and 1 partial ⚠️
...a/io/ballerina/lib/data/xmldata/xml/XmlParser.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
- Coverage     86.46%   85.79%   -0.67%     
- Complexity      556      562       +6     
============================================
  Files            25       25              
  Lines          2416     2591     +175     
  Branches        529      564      +35     
============================================
+ Hits           2089     2223     +134     
- Misses          187      218      +31     
- Partials        140      150      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SasinduDilshara SasinduDilshara marked this pull request as ready for review August 27, 2024 09:28
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Sep 21, 2024
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Sep 25, 2024
gimantha
gimantha previously approved these changes Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support union type as expected type for data.xmldata module.
4 participants