Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make distroless containers default in native path #728

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

xlight05
Copy link
Contributor

@xlight05 xlight05 commented Aug 3, 2023

Purpose

  1. Make distroless containers default in graalvm path
  2. Use mostly static linking in the container by default
  3. Make default flags not overridable in graalvm
  4. Update GraalVM version in native builder

Resolves https://github.com/ballerina-platform/module-ballerina-c2c/issues/723
Resolves https://github.com/ballerina-platform/module-ballerina-c2c/issues/736

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍🏼

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (6f81bfc) 82.39% compared to head (f0b19bc) 82.38%.
Report is 1 commits behind head on 2201.7.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.7.x     #728      +/-   ##
==============================================
- Coverage       82.39%   82.38%   -0.01%     
+ Complexity        396      395       -1     
==============================================
  Files              47       47              
  Lines            2170     2169       -1     
  Branches          268      268              
==============================================
- Hits             1788     1787       -1     
  Misses            253      253              
  Partials          129      129              
Files Changed Coverage Δ
...main/java/io/ballerina/c2c/DockerGenConstants.java 0.00% <ø> (ø)
.../io/ballerina/c2c/utils/NativeDockerGenerator.java 72.34% <ø> (-1.13%) ⬇️
...n/java/io/ballerina/c2c/utils/KubernetesUtils.java 81.16% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlight05 xlight05 merged commit d856d5e into ballerina-platform:2201.7.x Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants