-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing performance tests to use more "modern" coding styles #63
Update existing performance tests to use more "modern" coding styles #63
Conversation
63a321c
to
cf8ebde
Compare
}, | ||
verifyHostName: false | ||
} | ||
); | ||
|
||
service /transform on securedEP { | ||
resource function post .(http:Caller caller, http:Request req) { | ||
isolated resource function post .(http:Request req) returns http:Response { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why we are not using data binding instead?
if xmlPayload is xmldata:Error? { | ||
return getErrorResponse(xmlPayload, http:STATUS_BAD_REQUEST); | ||
} | ||
http:Request clinetreq = new; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, but also probably clientReq.
} | ||
xml|xmldata:Error? xmlPayload = xmldata:fromJson(payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably change these to use the new xmldata module?
if xmlPayload is xmldata:Error? { | ||
return getErrorResponse(xmlPayload, http:STATUS_BAD_REQUEST); | ||
} | ||
http:Request clinetreq = new; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
Purpose
$subject
Fix #43431
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning