Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of spaces in the classpath #43445

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Shadow-Devil
Copy link
Contributor

Purpose

If the path to the ballerina repo contains a space the build failed. This was fixed by changing the classPath of the :jballerina-tools:pathingJar to use .toURI() instead of .toURL(). This now escapes the spaces correctly with %20

Fixes #41090

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (0450329) to head (bb59e29).
Report is 101 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43445      +/-   ##
============================================
+ Coverage     77.49%   77.50%   +0.01%     
- Complexity    58594    58601       +7     
============================================
  Files          3438     3438              
  Lines        219263   219263              
  Branches      28925    28925              
============================================
+ Hits         169922   169950      +28     
+ Misses        39919    39891      -28     
  Partials       9422     9422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimantha gimantha merged commit ac0b842 into ballerina-platform:master Oct 7, 2024
18 checks passed
@Shadow-Devil Shadow-Devil deleted the issues/41090 branch October 7, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Could not build ballerina-lang repo when its path contains spaces
3 participants