Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to using Stack #43444

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

gimantha
Copy link
Contributor

@gimantha gimantha commented Oct 3, 2024

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gimantha gimantha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (0450329) to head (4f61e6a).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #43444   +/-   ##
=========================================
  Coverage     77.49%   77.49%           
- Complexity    58594    58596    +2     
=========================================
  Files          3438     3438           
  Lines        219263   219263           
  Branches      28925    28925           
=========================================
+ Hits         169922   169927    +5     
+ Misses        39919    39916    -3     
+ Partials       9422     9420    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shadow-Devil
Copy link
Contributor

Hi @gimantha, I'm curious why this is being reverted. Did something break with this change or was there some performance loss?

@gimantha
Copy link
Contributor Author

gimantha commented Oct 4, 2024

Hi @gimantha, I'm curious why this is being reverted. Did something break with this change or was there some performance loss?

@Shadow-Devil our initial thought was that itemGroup is not concurrently accessed.
It seems like ItemGroup is being accessed concurrently(I cannot confirm though) and intermittently level 2 standard libraries are failing. We will be only reverting that line only. Eventually this class will be remove with Java 21 migration.

@gimantha gimantha merged commit 50fe1c5 into ballerina-platform:master Oct 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants